Re: libtool 2.2.2, darwin and target prefixes

[Peter O'Gorman]

Peter O'Gorman wrote:
> Richard Purdie wrote:
>> Hi,
>>
>> As previously mentioned, I've been stress testing libtool 2.2.2 with
>> Poky a bit.
>>
>> I've found one issue when I tested the darwin builds, specifically that
>> it tried to use "otool" and "otool64" and not the versions with the host
>> prefix which my setup has. I fixed this with the patch below which is
>> fine for Poky since its always cross compiling but its a sign a better
>> fix is probably needed in general.
> 
> Thanks,
> I have pushed this, it also cleans up the sed sed echo ickyness.

It is always better if quotes get closed. I had tested, honest!

Pushed this.

Peter
-- 
Peter O'Gorman
http://pogma.com

>From fe06ce018f30c17b034c318f76bbe16164bf0d3a Mon Sep 17 00:00:00 2001
From: Peter O'Gorman <address@hidden>
Date: Fri, 2 May 2008 00:54:49 -0500
Subject: [PATCH] It helps to close quotes.

* libltdl/config/ltmain.m4sh (func_mode_link): Add closing '.
---
 ChangeLog                  |    5 +++++
 libltdl/config/ltmain.m4sh |    4 ++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 5db30d7..b9a695c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2008-05-02  Peter O'Gorman  <address@hidden>
+
+       It helps to close quotes.
+       * libltdl/config/ltmain.m4sh (func_mode_link): Add closing '.
+
 2008-05-01  Peter O'Gorman  <address@hidden>
 
        Use AC_CHECK_TOOL for otool and otool64.
diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh
index 84f7078..33689b9 100644
--- a/libltdl/config/ltmain.m4sh
+++ b/libltdl/config/ltmain.m4sh
@@ -4951,9 +4951,9 @@ func_mode_link ()
                    done
                    if test -f "$absdir/$objdir/$depdepl" ; then
                      depdepl="$absdir/$objdir/$depdepl"
-                     darwin_install_name=`${OTOOL} -L $depdepl | awk '{if (NR 
== 2) {print $1;exit}}`
+                     darwin_install_name=`${OTOOL} -L $depdepl | awk '{if (NR 
== 2) {print $1;exit}}'`
                       if test -z "$darwin_install_name"; then
-                          darwin_install_name=`${OTOOL64} -L $depdepl  | awk 
'{if (NR == 2) {print $1;exit}}`
+                          darwin_install_name=`${OTOOL64} -L $depdepl  | awk 
'{if (NR == 2) {print $1;exit}}'`
                       fi
                      compiler_flags="$compiler_flags ${wl}-dylib_file 
${wl}${darwin_install_name}:${depdepl}"
                      linker_flags="$linker_flags -dylib_file 
${darwin_install_name}:${depdepl}"
-- 
1.5.3.7