[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Don't install .la files when --no-la-files is used

From: Ralf Wildenhues
Subject: Re: [PATCH] Don't install .la files when --no-la-files is used
Date: Sun, 2 Nov 2008 21:59:18 +0100
User-agent: Mutt/1.5.18 (2008-05-17)

Hello Dan,

* Dan Nicholson wrote on Sat, Nov 01, 2008 at 09:48:28PM CET:
> Add an option, --no-la-files, which skips installing the .la files. When
> used with --mode=uninstall, libtool tries to use the .lai file from the
> build directory.
> Signed-off-by: Dan Nicholson <address@hidden>
> ---
>  Does this seem reasonable? I've checked that this doesn't break
>  uninstall or distcheck.

It does break third-party packages that would like to link against your
library.  So we should not encourage it.


> +     if ! $opt_no_la_files; then

FWIW, 'if !' is not portable, 'if $opt; then :; else ...' would be.

> +     if $opt_no_la_files; then
> +       file=.libs/"$name"i
> +       test -f "$file" || file=`find . -type f -name "$name"i`

Not safe when files with whitespace in the name are present.

> +       test -n "$file" || file=.libs/"$name"i
> +       func_dirname "$file" "" "."
> +       dir="$func_dirname_result"

reply via email to

[Prev in Thread] Current Thread [Next in Thread]