[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: plugins on the command line are renamed

From: Ralf Wildenhues
Subject: Re: plugins on the command line are renamed
Date: Mon, 19 Jan 2009 23:15:55 +0100
User-agent: Mutt/1.5.18 (2008-05-17)

Hello Paul,

* Paul Biggar wrote on Sun, Jan 11, 2009 at 11:04:05PM CET:
> I hope its not too soon to ping on this?

No, pinging is certainly ok, and, sigh, unfortunately necessary.  :-/

> On Wed, Dec 31, 2008 at 1:22 PM, Paul Biggar <address@hidden> wrote:
> > On Wed, Dec 31, 2008 at 8:43 AM, Ralf Wildenhues <address@hidden> wrote:
> >>> The point of interest is that both the executable name "src/phc" and
> >>> the .la file "plugins/tests/" have both been renamed
> >>> to "/home/pbiggar/phc_work/svn/branches/dataflow/src/.libs/lt-phc".,
> >>> which is correct for the former but not the latter.

Please try the patch below.

Others, ok to commit (and Paul, OK to put you in THANKS)?  I thought of
somehow changing the func_ltwrapper_script_p set of functions to only
match for wrappers for programs and not for objects or libraries, but am
currently reluctant to go this way.  Point here is that handling of *.lo
and *.la files is only special for arguments of -dlopen.


    execute mode: do not transform *.lo or *.la arguments.
    * libltdl/config/ltmain.m4sh (func_mode_execute): Do not check
    arguments matching *.lo or *.la for script wrappers.
    * tests/ (execute mode): Add tests.
    * NEWS, THANKS: Update.
    Report by Paul Biggar.

diff --git a/NEWS b/NEWS
index 759b7d2..2d713e7 100644
--- a/NEWS
+++ b/NEWS
@@ -30,6 +30,7 @@ New in 2.2.8 2009-??-??: git version 2.2.7a, Libtool team:
     only the default informational output. See New Features, --no-silent.
   - Link tests are guarded by cache variables so they can be avoided for
     bootstrapping purposes (e.g., when link tests are not possible).
+  - Argument mangling of execute mode has been improved (i.e., lessened).
 * Miscellaneous changes:
diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh
index 7e59338..608dcff 100644
--- a/libltdl/config/ltmain.m4sh
+++ b/libltdl/config/ltmain.m4sh
@@ -1319,7 +1319,7 @@ func_mode_execute ()
     for file
       case $file in
-      -*) ;;
+      -* | *.la | *.lo ) ;;
        # Do a test to see if this is really a libtool program.
        if func_ltwrapper_script_p "$file"; then
diff --git a/tests/ b/tests/
index a019e8e..ef0ac07 100644
--- a/tests/
+++ b/tests/
@@ -210,4 +210,11 @@ do
+# Check that .la files are not transformed by the wrapper searching loop.
+AT_CHECK([$LIBTOOL --mode=execute echo ./main liba.lo], [], 
+# This could be .libs/lt-main or similar (or just plain `main').
+AT_CHECK([grep main stdout], [], [ignore])
+AT_CHECK([grep liba.lo stdout], [], [ignore])
+AT_CHECK([grep stdout], [], [ignore])

reply via email to

[Prev in Thread] Current Thread [Next in Thread]