[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: When to bump library api version (current)

From: Daniel Herring
Subject: Re: When to bump library api version (current)
Date: Thu, 20 May 2010 00:36:00 -0400 (EDT)
User-agent: Alpine 2.00 (LNX 1167 2008-08-23)

On Wed, 19 May 2010, Adam Mercer wrote:

double calculate_ligo_snr_from_strain(
 REAL4TimeVectorSeries *strain,
 SimInspiralTable *thisInj,
 char ifo[3]);

has changed to:

double calculate_ligo_snr_from_strain(
 REAL4TimeVectorSeries *strain,
 SimInspiralTable *thisInj,
 const char ifo[3]);

i.e. the third argument has changed from char to const char, whilst
this is technically an API change I'm not sure if it warrants an API
bump? Should current be bumped in this case or is it OK not to bump
current (or bump both current and age)?

ISTM that this is not an ABI change; the addition of const only affects the code being called, and in a manner compatible with the non-const version (assuming calling code did not expect this parameter to be changed).

That said, C++ compilers do change the name mangling based on constness; so the above argument depends on your code being plain C.

See for example Table 9 in

- Daniel

reply via email to

[Prev in Thread] Current Thread [Next in Thread]