[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Removing LC_ALL=C from README-release [WAS Re: [PATCH] README-release im

From: Gary V. Vaughan
Subject: Removing LC_ALL=C from README-release [WAS Re: [PATCH] README-release improvements]
Date: Mon, 24 Oct 2011 20:36:22 +0700

[[Moving to libtool list][


On 21 Oct 2011, at 19:02, Gary V. Vaughan wrote:
> On 21 Oct 2011, at 16:11, Bruno Haible wrote:
>>> Set a neutral locale for rolling the release tarballs.
>> I disagree with this advice. Yes, the first time you run a "make distcheck"
>> in a German locale, 'makeinfo' may put German strings into your formatted
>> documentation. But "make distcheck" ought to work for any user as well
>> as for yourself. And many users will run "make check" in German, Japanese,
>> or Chinese locales. Therefore you should better fix the Makefile problems
>> that you have in this area, not push them under the rug.
> Git blame puts the introduction of the LC_ALL line to our release checklist
> here (which doesn't shed any light on it unfortunately):
> commit 2db08b36f61c63db299b1387fa974668d05465d3
> Author: Ralf Wildenhues <address@hidden>
> Date:   Tue Apr 26 11:55:12 2005 +0000
>   * HACKING, THANKS: Updated.
> I assume Ralf did this so that we can be certain of not accidentally uploading
> a release with German localisation strings in it, and/or because some of our
> test-cases break in another locale.  I haven't looked any deeper than that 
> tho'
> so I'm quite happy to leave it in gl/top/README-release.diff until I've had 
> the
> time to investigate properly.

I've just successfully bootstrapped and distchecked Libtool from a fresh clone
of the git repo, all with LC_ALL=zh_CN (which is a locale I have installed on
my machine according to `locale -a') in the environment.

Bruno is correct, that (apart from having to deal with gpg prompting me in
Chinese) this creates a distribution tarball identical to the one built with
LC_ALL=C in the environment, both of which pass the complete testsuite.

I'll remove the following line from the libtool README-release in 72 hours
unless someone tells why I shouldn't do that:

  * Make sure your locale is sane, e.g. by exporting LC_ALL=C.

Gary V. Vaughan (gary AT gnu DOT org)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]