Re: [PATCH] Document jit_align.

[Marc Nieper-Wißkirchen]

Am Di., 16. Aug. 2022 um 20:14 Uhr schrieb Paulo César Pereira de
Andrade <paulo.cesar.pereira.de.andrade@gmail.com>:
>
> Em dom., 14 de ago. de 2022 às 13:09, Marc Nieper-Wißkirchen
> <marc@nieper-wisskirchen.de> escreveu:
> >
> > I just noticed that the argument to jit_align is asserted to be at most as 
> > large as the size of a word in jit_x86.c (line 1596).  To make jit_align 
> > suitable for what the documentation was written for, the limit should be 
> > increased to, say, jit_get_max_instr().  For that, the nop generator in 
> > jit_x86-cpu.c has to be modified to allow longer sequences of nop (e.g. by 
> > iterating).
>
>   The idea for jit_align was indeed just to make it just align jump targets
> or function prologs.
>   Usually jumps to aligned addresses are faster.
>
>   The assertions should be changed.

I am going to put this on my TODO list as this involves improving the
nop-generators in the jit_xxx-cpu.c files. For that, I need the
128-bit opcode for a NOP on ia64.

Marc