lightning
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] ppc: Fix 'calli' when floating-point arguments are passed


From: Paulo César Pereira de Andrade
Subject: Re: [PATCH] ppc: Fix 'calli' when floating-point arguments are passed
Date: Tue, 23 Aug 2022 12:45:51 -0300

Em ter., 23 de ago. de 2022 às 12:31, Paul Cercueil
<paul@crapouillou.net> escreveu:
>
> Note that this patch fixes the 3to2 and varargs checks, but the
> following are still failing: cvt, fop_sqrt, clobber, call.

  Let's first check the most likely cause. For fop_sqrt.tst, please
test commenting with // or /* */ the lines that have either $NaN
or $Inf.
  Also in the first suspect, clobber.tst might be failing at:
         jmpf(__LINE__, unord,       0, $(0.0 / 0.0))
but please test bisecting the tests, until finding the one that fails.
It must be calling abort, running in a debugger would be a bit
easier to debug.

  For call.tst, please also bisect to find what test is failing. This
test does extensive checking on to/from float/double tests, and
to/from float/double/word tests as well as several validations on
special values, for 32 bit, values like 0x80000000, 0xffffffff,
0x7fffffff, 0x80000001 and the similar 8 and 16 bit values, to
check for proper conversions.

  It must be something simple like the patch you just did, or
might be a qemu-user bug.

> Cheers,
> -Paul

Thanks,
Paulo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]