[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5349 Constness of Grob methods

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

• Description has changed:

Diff:

--- old
+++ new
@@ -1 +1,6 @@
 Grob::internal_get_property is advertised as a const method, but it came up in a [code review](http://codereview.appspot.com/346100043) that "caching of values is not really conceptually const."  So, at the very least, the const is misleading.  It would be good to change it for clarity, but it might require a chain of consequential changes.
+
+More:
+> get_property_data is logically const (and used in a number of places to avoid premature callback evaluation).  Stream event and music properties, I think, also are.  get_object is, I think. get_pure_property may be (not entirely sure about that one, though).
+> 
+> We've had a number of early evaluation bugs, too, it's not really an academical distinction.  I'm not against making "const" more useful for deciding things but exactly in that case we want Grob::get_property_internal _not_ be const.

---

[issues:#5349] Constness of Grob methods

Status: Shelved
Created: Mon Jun 18, 2018 11:56 PM UTC by Dan Eble
Last Updated: Wed Jun 20, 2018 12:20 AM UTC
Owner: Dan Eble

Grob::internal_get_property is advertised as a const method, but it came up in a code review that "caching of values is not really conceptually const." So, at the very least, the const is misleading. It would be good to change it for clarity, but it might require a chain of consequential changes.

More:

get_property_data is logically const (and used in a number of places to avoid premature callback evaluation). Stream event and music properties, I think, also are. get_object is, I think. get_pure_property may be (not entirely sure about that one, though).

We've had a number of early evaluation bugs, too, it's not really an academical distinction. I'm not against making "const" more useful for deciding things but exactly in that case we want Grob::get_property_internal not be const.

---

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto