|
From: | Auto mailings of changes to Lily Issues via Testlilyissues-auto |
Subject: | [Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5258 Vertical breve rest position in TabStaff/RhythmicStaff |
Date: | Mon, 17 Dec 2018 12:02:35 -0000 |
Diff:
--- old +++ new @@ -1,2 +1,5 @@ +Regtest1.png (16.1 kB; image/png) +Regtest2.png (187.3 kB; image/png) breve_rests.png (26.0 kB; image/png) gould_breve_rests_oneline.png (27.9 kB; image/png) +regtest3.png (570.0 kB; image/png)
Passes mke, make check and a full make doc. Three Reg test diffs - attached.
[issues:#5258] Vertical breve rest position in TabStaff/RhythmicStaff
Status: Started
Created: Sat Jan 13, 2018 04:47 PM UTC by Malte Meyn
Last Updated: Sun Dec 16, 2018 01:23 PM UTC
Owner: Malte Meyn
Attachments:
https://codereview.appspot.com/332640043
According to Gould breve rests should hang from a one line staff (RhythmicStaff) as semibreve rests do. Also, there is a comment in multi-measure-rest.cc saying
// Staff position is somewhat icky regarding its definition for // compatibility reasons. It is intended to be the baseline of // a breve rest. However, when the staff space is more than // single space (like with tablature), it looks better if all // rests are actually hanging. So staff position, in reality, // is the semi-breve position - 2. Everything else is // calculated from there.
This confirms what Gould writes. But the code applies only to MMRs with a measure-count > 1.
That leads to inconsistent behaviour: MultiMeasureRest breve glyphs hang, but not for single measures. Rest breve glyphs don’t hang. Instead, all breve rests should hang.
\version "2.19.80" music = { \compressFullBarRests r1 R1 R\breve \time 4/2 r\breve R\breve R\longa \time 8/2 r\longa R\longa } \new TabStaff \with { \tabFullNotation } \music \new RhythmicStaff \music \new Staff \music
Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
_______________________________________________ Testlilyissues-auto mailing list address@hidden https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
[Prev in Thread] | Current Thread | [Next in Thread] |