|
From: | Auto mailings of changes to Lily Issues via Testlilyissues-auto |
Subject: | [Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5649 flower: Add boolean return value to 'Rational' class. |
Date: | Mon, 30 Dec 2019 11:35:42 -0000 |
"Werner LEMBERG" address@hidden writes:
Thanks for the diffs. It's surprising to me that there are any diffs
at all. I don't see any problematic differences, though.
[issues:#5649] flower: Add boolean return value to 'Rational' class.
Status: Started
Created: Sun Dec 29, 2019 10:08 AM UTC by Werner LEMBERG
Last Updated: Mon Dec 30, 2019 05:06 AM UTC
Owner: Werner LEMBERG
Attachments:-
test-results.zip
(497.6 kB; application/zip)This removes many clang warnings of the type
implicit conversion turns floating-point number into integer:
'double' to 'bool' [-Wfloat-conversion]
I think it would still be good to know how they come about. Maybe we
get zero values by having the numerator rather than the sign zero? If
so, it would be important to figure out where.
--
David Kastrup
[issues:#5649] flower: Add boolean return value to 'Rational' class.
Status: Started
Created: Sun Dec 29, 2019 10:08 AM UTC by Werner LEMBERG
Last Updated: Mon Dec 30, 2019 06:09 AM UTC
Owner: Werner LEMBERG
Attachments:
This removes many clang warnings of the type
implicit conversion turns floating-point number into integer:
'double' to 'bool' [-Wfloat-conversion]
https://codereview.appspot.com/581400043
Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
_______________________________________________ Testlilyissues-auto mailing list address@hidden https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
[Prev in Thread] | Current Thread | [Next in Thread] |