lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Patch to fix extra space in ChordNames (for 1.6.4)


From: Scott Ainsworth
Subject: Patch to fix extra space in ChordNames (for 1.6.4)
Date: Mon, 23 Sep 2002 14:07:52 -0400

I have found that the ChordNames context includes a space between the
chord name the inversion or bass note like this "Am /G".  I have traced
it to the chord::inner-chord-banter function in chord-name.scm:

(define (chord::inner-name-banter tonic exception-part additions
subtractions
                                  bass-and-inversion steps)
  (let* ((tonic-text (pitch->chord-name-text-banter tonic steps))
         (except-text exception-part)
         (sep-text (if (and (string-match "super" (format "~s"
except-text))
                            (or (pair? additions)
                                (pair? subtractions)))
                       (list simple-super "/")))
         (adds-text (chord::additions->text-banter additions
subtractions))
         (subs-text (chord::subtractions->text-banter subtractions))
         (b+i-text (chord::bass-and-inversion->text-banter
bass-and-inversion)))
    (text-append
HERE-------------------------|
     tonic-text except-text " " sep-text
HERE-------------------------^     ;;(list (list simple-super) adds-text
subs-text)
     (list (list '((raise . 1) (font-relative-size . -1))) adds-text
subs-text)
     b+i-text)))

Changing [" "] to [""] removes the space in the chord name and does not
appears to break anything in the process.  I have run all the regression
test examples that contain the ChordNames context and have not found any
strange results.  The patch is attached.  I will send a patch for 1.7.0
separately.

Scott Ainsworth

Attachment: chord-name-1.6.4-patch.diff
Description: Binary data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]