Merging different fonts

[Han-Wen Nienhuys]

address@hidden writes:
> When running lilypond (I'm using 2.1.27), if you have 2 voices with 
> different note head styles (fonts), the program will merge colliding 
> notes, losing one of the fonts.  The problem is shown in this example:
> 
> \score { \notes { << { d'4 c'4 }
>         \\ \override NoteHead #'style = #'diamond
>         { c'4 c'4 } >> r2 } }
> \paper {
>     indent = 0.0\mm
>     raggedright = ##t
> }
> 
> 
> I created a patch.  I also added a property (merge-differently-fonted) 
> to allow the original behavior.  The patch includes the source files as 
> well as the user manual.  I also created a file for the regression 
> tests.  Below are the 1. the patch, and 2. the regression test.  I've 
> been following the mailing list for a few weeks now, and I think this is 
> the format you want (diff -u, no attachments, etc.).  If you want 
> something else, let me know.

Patch looks OK in principle, but I have some further questions and comments.

* Can you think of any case where merge-differently-fonted is
necessary? If not, then we can skip that option, and simply never
merge if styles are different.

* Secondly, why define Note_head::get_font_name ()?  Doesn't it work
if you do

   gh_equal_p (up_note->get_property ("style"),
               down_note->get_property ("style"))

?

* Final formatting nitty gritty nitpick: we want spaces before opening
  parentheses, ie.

    function_call ()

  instead of

    function_call()


-- 

 Han-Wen Nienhuys   |   address@hidden   |   http://www.xs4all.nl/~hanwen