|
From: | Han-Wen Nienhuys |
Subject: | Re: tuplet bugfix |
Date: | Wed, 07 Jun 2006 18:19:32 +0200 |
User-agent: | Thunderbird 1.5.0.2 (X11/20060501) |
Erik Sandberg schreef:
On Wednesday 07 June 2006 00:09, Han-Wen Nienhuys wrote:Erik Sandberg schreef:Hi, The attached patch makes tupletSpannerDuration work again.hi, I'm missing GC mark functions. You'll need a Time_scaled_music_iterator::derived_mark(), which marks the start_ and stop_ members.Ah, you're right. (I thought Sequential_iterator would take care of that, but now there's a short period between start_ is initialized and it's protected by Sequential_iterator). New patch attached.
looks good. Please apply after testing.
+ start_ and stop_. This trickery has been built for const + correctness reasons.
I would delete this part. It's not obvious that you have to do stuff in get_music()
-- Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen LilyPond Software Design -- Code for Music Notation http://www.lilypond-design.com
[Prev in Thread] | Current Thread | [Next in Thread] |