Re: lilypond ChangeLog scripts/lilypond-book.py

[Han-Wen Nienhuys]

Mats Bengtsson schreef:
> CVSROOT:        /sources/lilypond
> Module name:    lilypond
> Changes by:     Mats Bengtsson <matsb>    06/10/04 11:14:43
>
> Modified files:
> 	.              : ChangeLog 
> 	scripts        : lilypond-book.py 
>
> Log message:
>                 * scripts/lilypond-book.py (bindir): Use os.path.join to add the
>                 path, in order to get correct path separators on all platforms.
>
> CVSWeb URLs:
> http://cvs.savannah.gnu.org/viewcvs/lilypond/ChangeLog?cvsroot=lilypond&r1=1.5366&r2=1.5367
> http://cvs.savannah.gnu.org/viewcvs/lilypond/scripts/lilypond-book.py?cvsroot=lilypond&r1=1.342&r2=1.343
>
> Patches:
> Index: ChangeLog
> ===================================================================
> RCS file: /sources/lilypond/lilypond/ChangeLog,v
> retrieving revision 1.5366
> retrieving revision 1.5367
> diff -u -b -r1.5366 -r1.5367
> --- ChangeLog   4 Oct 2006 10:51:57 -0000       1.5366
> +++ ChangeLog   4 Oct 2006 11:14:42 -0000       1.5367
> @@ -1,3 +1,8 @@
> +2006-10-04  Mats Bengtsson  <address@hidden>
> +
> +       * scripts/lilypond-book.py (bindir): Use os.path.join to add the
> +       path, in order to get correct path separators on all platforms.
> +
>  2006-10-04  Han-Wen Nienhuys  <address@hidden>
>  
>  	* scm/backend-library.scm: update email address.
>
> Index: scripts/lilypond-book.py
> ===================================================================
> RCS file: /sources/lilypond/lilypond/scripts/lilypond-book.py,v
> retrieving revision 1.342
> retrieving revision 1.343
> diff -u -b -r1.342 -r1.343
> --- scripts/lilypond-book.py    4 Oct 2006 09:24:55 -0000       1.342
> +++ scripts/lilypond-book.py    4 Oct 2006 11:14:43 -0000       1.343
> @@ -48,7 +48,7 @@
>  # dynamic relocation, for GUB binaries.
>  bindir = os.path.abspath (os.path.split (sys.argv[0])[0])
>  
> -os.environ['PATH'] = bindir + ':' + os.environ['PATH']
> +os.environ['PATH'] = os.path.join(bindir,os.environ['PATH'])

this won't work. os.path.join uses '/' to concatenate.



--

Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen

LilyPond Software Design
 -- Code for Music Notation
http://www.lilypond-design.com