Re: MusicXML: Conversion of various types of spanners (octave, pedals, trills)

[Han-Wen Nienhuys]

2007/9/13, Reinhold Kainhofer <address@hidden>:
> >    # TODO: setting dashed/dotted line style does not work, because that
> > +        #       command needs to be written before the note, not when the
> > +        #       event is observed after the note!
> > +        #if self.line_type == 1:
> > +            #before = '\\slurDotted'
> > +        #elif self.line_type == 2:
> > +            #before = '\\slur
> >
> >
> > if False:
> >   ..block..
> > is shorter

if you want to comment out a section in python, using

  if 0:
     commented_out_statements()

is shorter, and less of a mess wrt. comment signs.

> >  spanner_type_dict = {
> >      'start': -1,
> >      'begin': -1,
> > +    'up': -2,
> > +    'down': -1,
> >      'stop': 1,
> >      'end' : 1
> >  }
> >
> > Don't do this; this is very nonstandard within lilypond. -1 =
> > left/down/start, 1 = right/up/stop,  0 = center.
>
> Ottava bracket elements have three different types: up, down and stop.
> A similar problem happens with hairpin crescendos, where the possible types
> are crescendo / diminuendo / stop. (Yes, both use inconsistent values
> currently, I know)
> What's the preferred way to treat these in lilypond?

Like they are treated inside lilypond itself. Eg. for hairpins, there
are 2 direction properties:

 span-dir (start/stop)
 grow-dir (cresc/descresc)

> >          self.span_direction = 0
> > +        self.line_type = 0
> > +        self.size = 0
> >
> >
> > why is line_type encoded as an int? It's clearer if you just use a
> > string ('wavy', 'dotted', etc.)
>
> I used an int since span_direction was also using an int...


please change this. Line type does not have a natural assignment of integers.

-- 
Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen