[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Patch for fret diagrams
From: |
Han-Wen Nienhuys |
Subject: |
Re: Patch for fret diagrams |
Date: |
Sat, 6 Oct 2007 18:28:29 -0300 |
2007/10/6, Carl D. Sorensen <address@hidden>:
> I've completed the refactoring of the fret-diagram code, eliminating the
> destructive writes and converting them to prepends.
ok: I have a final nit: can you remove debugging code and commented
out code? If you've commented out something you want to keep around,
please add comment explaining it
Also, merged-alist-values is not completely cleaar to me. Maybe you
could migrate some of the text from the commit message to the
docstring? One cause for concern is the (append .. ) inside a
recursive function. Append is rather wasteful of memory and cpu, since
it has to traverse all of its argument.
--
Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen