Re: Patch to autobeaming code.

[Han-Wen Nienhuys]

On Sat, Aug 16, 2008 at 5:55 PM, Carl D. Sorensen <address@hidden> wrote:
> I've been trying to figure out how to use beatLength to make the rhythms
> documentation correct.
>
> Issue #511 makes it sound like beatLength is used to create autobeaming
> responses.   And it works for "odd" timing.  However, for standard timings,
> it doesn't work properly.
>
> For example, in 12/16 music, when beatLength is set to 1/8, instead of
> creating beams that will end every 1/8 note (which is the expected
> behavior according to issue 511), beatLength has the effect of setting
> the autobeaming behavior to match 6/8 time.  I believe this is the designed
> behavior -- autobeaming should be based on beatLength, not the denominator
> of the time signature.

You analysis is correct, but I think the solution should be that
rewriting 12/16 to 6/8 based on beatlength is the wrong thing to do,
and will confuse users - since their 12/16 settings will be ignored.
Before we start introducing new functionality, I think we should fix
this first.

> Note that the autobeam settings for 6/8 time are to end at 3/8; this is
> what happens.
>
> I believe the correct response is to use the measure-grouping property to
> calculate autobeams, instead of beatLength.
>
> A known issue of Time signatures is that "Automatic beaming does not use
> the measure grouping specified with set-time-signature".
>
> I have now created a patch to scm/auto-beaming.scm that ends beams as
> specified in beatGrouping.  I've attached the patch, as well as a file
> that tests its functionality.

I'm missing the reg tests so we can see what kind of impact this change has.

-- 
Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen