lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Add a ly:line-thickness callback for scheme, returning the line thi


From: Reinhold Kainhofer
Subject: Re: Add a ly:line-thickness callback for scheme, returning the line thickness
Date: Sun, 21 Sep 2008 16:19:31 +0200
User-agent: KMail/1.9.10

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Freitag, 12. September 2008 schrieb address@hidden:
> http://codereview.appspot.com/5073/diff/601/403
> File lily/staff-symbol-referencer-scheme.cc (right):
>
> http://codereview.appspot.com/5073/diff/601/403#newcode41
> Line 41: LY_DEFINE (ly_line_thickness, "ly:line-thickness",
> can you work staff-symbol in the name?
>
> http://codereview.appspot.com/5073/diff/601/403#newcode47
> Line 47: Real thickness = g ? Staff_symbol_referencer::line_thickness
> (g) : -1;
> no need to check here.  You crash if it is not (the LY_ASSERT_SMOB case)
>
> http://codereview.appspot.com/5073

Okay, I now worked in those comments: 
- -) Renamed to ly:staff-symbol-line-thickness
- -) Removed that check

Latest patch can be found at
http://codereview.appspot.com/5073#ps-411-pointer

Okay to apply to master?

Cheers,
Reinhold

- -- 
- ------------------------------------------------------------------
Reinhold Kainhofer, Vienna University of Technology, Austria
email: address@hidden, http://reinhold.kainhofer.com/
 * Financial and Actuarial Mathematics, TU Wien, http://www.fam.tuwien.ac.at/
 * K Desktop Environment, http://www.kde.org, KOrganizer maintainer
 * Chorvereinigung "Jung-Wien", http://www.jung-wien.at/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFI1lf6TqjEwhXvPN0RAkJpAKDXxhPf5VUpD9keIVpP8NI+F3YAdQCdH4oH
wPbm8Q+aT/ZaFthpoYGSR40=
=2aaK
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]