lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

* Use scm_to_int64/from_int64 for Rational/SCM conversions.


From: hanwenn
Subject: * Use scm_to_int64/from_int64 for Rational/SCM conversions.
Date: Sun, 21 Sep 2008 11:43:44 -0700

Reviewers: Neil Puttock,

Message:
LGTM - this is what I meant.


http://codereview.appspot.com/5889/diff/1/6
File lily/moment.cc (right):

http://codereview.appspot.com/5889/diff/1/6#newcode134
Line 134: {
If you want to be paranoid, you could check that the most significant
bit is 1 here.

Description:

Also use I64 in moment.cc, moment-scheme.cc and duration-scheme.cc.

Please review this at http://codereview.appspot.com/5889

Affected files:
  M lily/duration-scheme.cc
  M lily/include/moment.hh
  M lily/lily-guile.cc
  M lily/moment-scheme.cc
  M lily/moment.cc






reply via email to

[Prev in Thread] Current Thread [Next in Thread]