[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: showFirstLength
From: |
v . villenave |
Subject: |
Re: showFirstLength |
Date: |
Mon, 20 Oct 2008 10:57:44 -0700 |
I don't know what to do next; should I open a new issue with the updated
code? Or is it possible to upload a new patch within the same issue?
http://codereview.appspot.com/7317/diff/1/4
File scm/music-functions.scm (right):
http://codereview.appspot.com/7317/diff/1/4#newcode827
Line 827: "set skipTypesetting, make SkipMusic of the given MUS length,
On 2008/10/20 12:17:00, hanwenn wrote:
update doc string mus suggests music argument, but you are passing a
moment.
Done.
http://codereview.appspot.com/7317/diff/1/4#newcode836
Line 836: (ly:moment-main-denominator mus)))
On 2008/10/20 12:17:00, hanwenn wrote:
this looks like a good candidate for a function
make-duration-of-music-length
Done.
http://codereview.appspot.com/7317/diff/1/4#newcode836
Line 836: (ly:moment-main-denominator mus)))
On 2008/10/20 12:17:00, hanwenn wrote:
this looks like a good candidate for a function
make-duration-of-music-length
would a define-public be potentially useful here?
Where should I put this function?
There's already a (remotely related) skip-of-length function at the
bottom of this file; should I move all debugging-related functions to
the bottom as well?
http://codereview.appspot.com/7317/diff/1/4#newcode841
Line 841: "unset skipTypesetting if set, make SkipMusic of the given MUS
length,
On 2008/10/20 12:17:00, hanwenn wrote:
update doc string: you're always unsetting
Done.
http://codereview.appspot.com/7317/diff/1/4#newcode843
Line 843: (make-sequential-music
On 2008/10/20 12:17:00, hanwenn wrote:
fix indent ; use emacs indent-region
Done.
http://codereview.appspot.com/7317/diff/1/4#newcode867
Line 867: ((show-last (ly:parser-lookup parser 'showLastLength))
On 2008/10/20 12:17:00, hanwenn wrote:
one space after var name.
Done.
http://codereview.appspot.com/7317/diff/1/4#newcode884
Line 884: 'symbol 'whichBar)))
On 2008/10/20 12:17:00, hanwenn wrote:
you may want to do this in 'Timing context.
Done.
http://codereview.appspot.com/7317
Re: showFirstLength, hanwenn, 2008/10/20
Re: showFirstLength, v . villenave, 2008/10/21