Re: [PATCHES] Re: Remarks about the building process

[Joe Neeman]

On Sat, 2008-11-08 at 16:59 -0200, Han-Wen Nienhuys wrote:
> 2008/11/5 John Mandereau <address@hidden>:
> 
> >
> > See also the other attached patch.
> >
> 
> 
> +#define EPSNULL 1e-12
> 
>  static void
>  print_buildings (list<Building> const &b)
> @@ -215,6 +216,9 @@ Skyline::internal_merge_skyline (list<Building>
> *s1, list<Building> *s2,
>        if (end >= s1->front ().end_)
>       s1->pop_front ();
> 
> +      if (abs (end - x) < EPSNULL)
> +     break;
> +
> 
> this looks fishy.  Why another EPS value?  Joe?

Is this some leftover code from our 80-bit floating point days? It
doesn't look right to me, but it looks identical to this patch from May:
http://www.nabble.com/Infinite-loop-with-GCC-4.3-td17303650.html

Joe