[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Nested book parts
From: |
nicolas . sceaux |
Subject: |
Re: Nested book parts |
Date: |
Sun, 16 Nov 2008 04:16:58 -0800 |
http://codereview.appspot.com/4848/diff/806/615
File lily/page-breaking.cc (right):
http://codereview.appspot.com/4848/diff/806/615#newcode227
Line 227: ly_symbol2scm ("is-part-last"), scm_from_bool (last),
On 2008/11/03 00:27:51, joeneeman wrote:
A really minor naming nitpick, but you have is-last and is-part-last
in the page
properties, part-is-last in the paper block and is-part-last-page as a
titling
predicate. Of these, is-part-last and is-part-last-page mean the same
thing
(AFAICT), but is-last and part-is-last are completely different from
each other
and from the other 2. Could you make the names more clear (I have no
objection
to verbose names for things with broad visibility, maybe something
like
is-last-page-from-bookpart and is-last-bookpart)?
Done: use is-bookpart-last-page and is-last-bookpart everywhere
http://codereview.appspot.com/4848