Re: Implement straight flags in scheme

[hanwenn]

some small comments, please apply


http://codereview.appspot.com/11046/diff/19/205
File scm/flag-styles.scm (right):

http://codereview.appspot.com/11046/diff/19/205#newcode20
Line 20: Note that here length is the whole length, while flag-x-width
is just the
drop: Note that

http://codereview.appspot.com/11046/diff/19/205#newcode45
Line 45: "Internal function to recursively create a stencil with
@code{remain} flags
Cool. if the function is internal, a single line doc str usually
suffices.

http://codereview.appspot.com/11046/diff/19/205#newcode64
Line 64: (stem-up? (eqv? dir UP))
ok - as a nitpick, the foo? is usually reserved for functions that
return bool, rather than the variables.  The lilypond code base is not
very consistent with that though.

http://codereview.appspot.com/11046/diff/19/205#newcode67
Line 67: (fs (ly:grob-property stem-grob 'font-size))
you can pass 0 as default arg, so you can put the call into the magstep
arg directly.

http://codereview.appspot.com/11046/diff/19/205#newcode75
Line 75: (down-off (polar->rectangular down-length downflag-angle))
this still looks repeated between up & down. Use

  (flag-length (if flagup? upflag-length downflag-length))

and fold cases.

http://codereview.appspot.com/11046