Re: [PATCH] Fix naming of two Scheme type predicates

[Patrick McCarty]

On Tue, Dec 30, 2008 at 7:29 PM, Carl D. Sorensen <address@hidden> wrote:
>
> On 12/30/08 7:10 PM, "Patrick McCarty" <address@hidden> wrote:
>
>> * Two exported Scheme functions did not follow the
>>   naming convention for type predicates.  This patch
>>   fixes the issue.
>
> Have you checked to see whether the exported functions are
> used anywhere in the scheme code base?

Yes, I have.  They are not used anywhere.  `listener' is used in
scm/part-combiner.scm, but only as a local variable.

> Also, this probably requires a convert-ly rule, because
> user code could have included the dispatcher predicate
> instead of ly:dispatcher?.

That's true.  It's unlikely, since AFACIS, the dispatcher/listener
stuff in mostly implemented on the C++ side, but since these
predicates were documented, we should probably have a convert-ly rule.

> And if it does require a convert-ly rule, it would have
> to wait until 2.13.

Okay, then I'll keep the patch on hold for a while.

Thanks,
Patrick