[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Updates to fret-diagrams
From: |
hanwenn |
Subject: |
Re: Updates to fret-diagrams |
Date: |
Sun, 04 Jan 2009 23:02:01 +0000 |
I agree with joe that there is a lot of duplicate here; it must be
possible to rewrite this more tightly.
That said, the fret-diagram code is completely your domain, so it's your
call.
http://codereview.appspot.com/11857/diff/1/4
File scm/fret-diagrams.scm (right):
http://codereview.appspot.com/11857/diff/1/4#newcode189
Line 189: (let* ((sth (* th size))
this indent is broken.
Also, I used to write rather abbreviated var names like sth, but I now
think it is better to be more verbose. However, it looks as if sth is
not used at all.
http://codereview.appspot.com/11857