[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Patch for review, [Was: Re: partial measure with independent time si
From: |
Neil Puttock |
Subject: |
Re: Patch for review, [Was: Re: partial measure with independent time signatures] |
Date: |
Thu, 5 Mar 2009 23:49:45 +0000 |
2009/2/25 Mats Bengtsson <address@hidden>:
> I haven't learned the new system for reviewing patches yet.
> Can you see any problems of applying the following patch? It
> solves the problem described below, and it doesn't seem to break anything.
>
> --- lily/parser.yy~ 2009-01-29 16:56:08.000000000 +0100
> +++ lily/parser.yy 2009-02-25 19:06:07.000000000 +0100
> @@ -1555,7 +1555,7 @@
> | PARTIAL duration_length {
> Moment m = - unsmob_duration ($2)->get_length ();
> $$ = MAKE_SYNTAX ("property-operation", @$, SCM_BOOL_F,
> ly_symbol2scm ("Timing"), ly_symbol2scm ("PropertySet"), ly_symbol2scm
> ("measurePosition"), m.smobbed_copy ());
> - $$ = MAKE_SYNTAX ("context-specification", @$, ly_symbol2scm
> ("Score"), SCM_BOOL_F, $$, SCM_EOL, SCM_BOOL_F);
> + $$ = MAKE_SYNTAX ("context-specification", @$, ly_symbol2scm
> ("Timing"), SCM_BOOL_F, $$, SCM_EOL, SCM_BOOL_F);
> }
>
> | TIME_T fraction {
Unfortunately it segfaults on midi-partial.ly, which I see Han-Wen
added just before reverting exactly the same patch as above. :)
\score {
{ \partial 4
c4 c1
}
\midi {
}
}
Regards,
Neil
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: Patch for review, [Was: Re: partial measure with independent time signatures],
Neil Puttock <=