Re: [frogs] patch for issue 708

[Andrew Hawryluk]

On Sun, May 24, 2009 at 7:14 AM, Carl D. Sorensen <address@hidden> wrote:
>
>
>
> On 5/24/09 4:49 AM, "Neil Puttock" <address@hidden> wrote:
>
>> 2009/5/24 Carl D. Sorensen <address@hidden>:
>>> Thanks,  Applied.
>>
>> Unfortunately, there are two serious flaws here:
>>
>> - keySignature alists which aren't backquoted (e.g., the example in
>> the bug tracker) will be ignored
>>
>> - entries of the form (notename . alteration) are mangled:
>>
>> \set Staff.keySignature = #'((0 . 2) (1 . 2)  (4 . 2))
>>
>> -> \set Staff.keySignature = #`(((0 . 2) . ,SEMI-SHARP)
>>                              ((2 . 4) . ,SHARP))
>>
>> Less seriously, the two conversion functions appear to be identical
>> apart from the different dictionaries for alterations.  Would it be
>> possible to use a single `fixKS' function with the dictionaries passed
>> as an argument to cut down on the duplication?
>
>
> Thanks for catching this, Neil.
>
> Andrew, I've reverted the patch.  Could you rewrite it to fix these issues?


Yes, I'll take a look at it. Thanks, Neil for catching those!
Won't be this week, but I'll keep you posted.

Andrew