Re: output-distance.py

[Han-Wen Nienhuys]

On Mon, Sep 28, 2009 at 11:40 AM, Graham Percival
<address@hidden> wrote:
> script/output-distance.py is broken.  I suspect that the general
> out/lybook-db/ thing is the problem -- when I look at self.missing and
> self.added (say, adding a print to line 818 of
> scripts/build/output-distance.py ), I see tons and tons of files.
>
> This is confirmed by the following test:
> address@hidden:~/tmp$ ls
> 2.13.3  lilypond-2.13.3-0.test-output.tar.bz2
> 2.13.5  lilypond-2.13.5-HEAD.test-output.tar.bz2
> address@hidden:~/tmp$ find . -name "*.ly" | xargs grep
> accidental-ancient
> ./2.13.3/regression/out-test/11/lily-6a1f0270.ly:\sourcefilename
> "/home/lilypond/gub/target/linux-x86/src/lilypond-git.sv.gnu.org--lilypond.git-master/input/regression/accidental-ancient.ly"
> ./2.13.5/regression/out-test/b4/lily-397060d1.ly:\sourcefilename
> "/main/src/gub/target/linux-x86/src/lilypond-git.sv.gnu.org--lilypond.git-master/input/regression/accidental-ancient.ly"
> address@hidden:~/tmp$
>
> I can't see how output-distance.py could track files across such changes.
>
> So... how are the directories and hashes generated?  If it's
> machine-specific, then we have a hope -- we can't generate a
> comparison between 2.13.3 and 2.13.5, but at least later comparisons
> will be possible.

The files are generated as a md5 (IIRC) hash of the contents, minus
\version, which has always been stripped. Of course, if someone goes
around modifying the templates in lilypond-book.py, all the hashes
change, and the comparison does not work anymore.  It might be a good
idea to also strip the lp-book boilerplate from the input to the hash.

-- 
Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen