Re: [PATCH] includeGraceNotes: lyrics syllables of grace notes

[Richard Gay]

Sorry to reply only after providing a second version of the patch ...
put the blame on my spam filter.

On Tue, 30 Mar 2010 19:52:29 +0100, Graham Percival
<address@hidden> wrote:
> Wow, thanks!  Especially for the doc parts.  I can't speak to the
> code, but there's a few doc policy issues.
> 
> Also, could we get a regression test for this feature?  See
> input/regression/
Will work on that.

> We try to avoid writing text like @code{includeGraceNotes} and
> simply say "By default... when using @code{\lyricsto}, but this
> behavior can be changed:"
Apparently I used the wrong "template" for my doc part (namely, the
ignoreMelismata setting). Will change this with the next version of the
patch.

> Another issue is that we try to avoid having tweaks in the main NR
> text; these should be added as snippets.  However, the rest of
> Vocal music is a complete mess, and we don't have any doc editors
> trained in dealing with snippets, so I'm fine with adding it to
> the main text for now.
Will change that, too. There even is a snippet "example" in vocal.itely
which I will imitate.

> > address@hidden,ragged-right,quote]
> > +<<
> > +  {
> > +   f'4 \appoggiatura b'32 c''4
> > +   \grace { f'16 [a'16] } c''2
> 
> No tabs; indentation rule is two spaces per level. [...]
Fixed that already in my second version of the patch. Thanks for the
hint.

Cheers,
Richard