Rationalize string number handling for notes and chords (issue906045)

[n . puttock]

Hi Carl,

LGTM.

Regarding the style nitpicks, fixcc.py will sort all these out
automatically (though it does still have the annoying habit of
reformatting the trailing closing parenthesis in the
ADD_TRANSLATOR/ADD_INTERFACE macros).

Cheers,
Neil


http://codereview.appspot.com/906045/diff/1/3
File lily/articulations.cc (right):

http://codereview.appspot.com/906045/diff/1/3#newcode4
lily/articulations.cc:4: Copyright (C) 2010--2010  Carl Sorensen
<address@hidden>
2010  Carl Sorensen

(make grand-replace will fail to update otherwise)

http://codereview.appspot.com/906045/diff/1/3#newcode37
lily/articulations.cc:37: articulation_list (vector<Stream_event*>
note_events,
Stream_event *

http://codereview.appspot.com/906045/diff/1/3#newcode38
lily/articulations.cc:38: vector<Stream_event*> articulation_events,
Stream_event *

http://codereview.appspot.com/906045/diff/1/3#newcode39
lily/articulations.cc:39: const char* articulation_name)
char const *articulation_name

http://codereview.appspot.com/906045/diff/1/3#newcode58
lily/articulations.cc:58: !articulation_event && scm_is_pair (s); s =
scm_cdr (s))
indent

http://codereview.appspot.com/906045/diff/1/3#newcode63
lily/articulations.cc:63: articulation_event = art;
indent

http://codereview.appspot.com/906045/diff/1/3#newcode79
lily/articulations.cc:79: articulation_event->self_scm () :
indent

((articulation_event
  ? articulation_event->self_scm ()
  : SCM_EOL),

http://codereview.appspot.com/906045/diff/1/3#newcode86
lily/articulations.cc:86: return (articulations);
return scm_reverse (articulations);

http://codereview.appspot.com/906045/diff/1/5
File lily/include/articulations.hh (right):

http://codereview.appspot.com/906045/diff/1/5#newcode4
lily/include/articulations.hh:4: Copyright (C) 2010--2010 Carl Sorensen
<address@hidden>
2010 Carl Sorensen

http://codereview.appspot.com/906045/diff/1/5#newcode26
lily/include/articulations.hh:26: SCM articulation_list
(vector<Stream_event*> notes,
Stream_event *

http://codereview.appspot.com/906045/diff/1/5#newcode27
lily/include/articulations.hh:27: vector<Stream_event*> articulations,
Stream_event *

http://codereview.appspot.com/906045/diff/1/5#newcode28
lily/include/articulations.hh:28: const char* articulation_name);
char const *articulation_name

http://codereview.appspot.com/906045/diff/1/6
File lily/tab-note-heads-engraver.cc (right):

http://codereview.appspot.com/906045/diff/1/6#newcode83
lily/tab-note-heads-engraver.cc:83: SCM tab_notes =
ly_cxx_vector_to_list(note_events_);
ly_cxx_vector_to_list (note_events_);

http://codereview.appspot.com/906045/diff/1/6#newcode87
lily/tab-note-heads-engraver.cc:87: string_fret_finger = scm_call_3
(proc,
indent

http://codereview.appspot.com/906045/show