[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Don't hardcode a limited set of markup signatures. (issue969046)
From: |
dak |
Subject: |
Re: Don't hardcode a limited set of markup signatures. (issue969046) |
Date: |
Sat, 01 May 2010 17:50:12 +0000 |
Reviewers: hanwenn,
http://codereview.appspot.com/969046/diff/2001/3002
File lily/lexer.ll (right):
http://codereview.appspot.com/969046/diff/2001/3002#newcode542
lily/lexer.ll:542: yylval.scm = scm_car(s);
On 2010/05/01 17:13:32, hanwenn wrote:
can you document the contents of s in a comment here, for old farts
like me that
forgot how this works?
It's not exactly like it had been documented previously.
http://codereview.appspot.com/969046/diff/2001/3002#newcode542
lily/lexer.ll:542: yylval.scm = scm_car(s);
On 2010/05/01 17:13:32, hanwenn wrote:
can you document the contents of s in a comment here, for old farts
like me that
forgot how this works?
Done.
Description:
Don't hardcode a limited set of markup signatures.
Please review this at http://codereview.appspot.com/969046/show
Affected files:
M Documentation/extending/programming-interface.itely
M lily/lexer.ll
M lily/parser.yy
M scm/markup.scm
- Don't hardcode a limited set of markup signatures. (issue969046), hanwenn, 2010/05/01
- Re: Don't hardcode a limited set of markup signatures. (issue969046),
dak <=
- Re: Don't hardcode a limited set of markup signatures. (issue969046), hanwenn, 2010/05/01
- Re: Don't hardcode a limited set of markup signatures. (issue969046), dak, 2010/05/02
- Re: Don't hardcode a limited set of markup signatures. (issue969046), Han-Wen Nienhuys, 2010/05/02
- Re: Don't hardcode a limited set of markup signatures. (issue969046), David Kastrup, 2010/05/02
- Re: Don't hardcode a limited set of markup signatures. (issue969046), Han-Wen Nienhuys, 2010/05/02
- Re: Don't hardcode a limited set of markup signatures. (issue969046), David Kastrup, 2010/05/02
- Re: Don't hardcode a limited set of markup signatures. (issue969046), Han-Wen Nienhuys, 2010/05/02
- Re: Don't hardcode a limited set of markup signatures. (issue969046), David Kastrup, 2010/05/03
- Re: Don't hardcode a limited set of markup signatures. (issue969046), Han-Wen Nienhuys, 2010/05/03
- Re: Don't hardcode a limited set of markup signatures. (issue969046), Kieren MacMillan, 2010/05/03