[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: PATCH: Eliminate PDF deletion in Windows
From: |
Patrick McCarty |
Subject: |
Re: PATCH: Eliminate PDF deletion in Windows |
Date: |
Wed, 5 May 2010 18:21:57 -0700 |
On Thu, Apr 29, 2010 at 8:32 PM, Carl Sorensen <address@hidden> wrote:
> On 4/27/10 10:49 PM, "Nathan Reed" <address@hidden> wrote:
>
>> Lilypond would attempt to delete the output PDF before overwriting it in
>> Windows
>> (but no other platforms). This is unnecessary and causes problems with
>> certain
>> PDF viewers, e.g. Sumatra, where the PDF is kept open in a way that allows
>> overwriting but not deletion. See also the discussion on bug-lilypond[1].
>
> I've reviewed this patch, and it looks good to me. I don't run LilyPond on
> Windows. Nathan has tested with multiple PDF viewers, and it seems to be
> better on some and no worse on any of them that have been tested.
It looks fine to me too.
> Are there any objections to having me push this patch?
I've just pushed it.
Thanks,
Patrick
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: PATCH: Eliminate PDF deletion in Windows,
Patrick McCarty <=