Re: [PATCH] hopefully fix #1036

[Francisco Vila]

2010/5/17 Graham Percival <address@hidden>:
> On Mon, May 17, 2010 at 2:33 AM, Francisco Vila <address@hidden> wrote:
>> This fixes translated bigpages by making
>
> However, it breaks the webpage; we now have links like
>  introduction.html#introduction
> instead of
>  introduction.html#Introduction
>
> as a result, clicking on links in the webpage takes you to a page
> which is slightly "scrolled down" from the top of the page, so you
> can't see the navbars and search at the top of the page.  I can't
> accept the patch in its current state.

Oh, no problem.  As I said, I know it needs more work.

As for the scrolled down problem: when it supposedly "worked well", it
only did because the links were wrong, they did not match with the
anchors.  So, the browser renders the whole page, because the filename
is correct but the target does not exist.

Now the anchors and the targets do match. So, if the page scrolls down
is only because a flaw in our page design: we'd have to put a link at
the top of a page which link to, not rely on that broken links will
result on the page being fully showed.


> I'm also not at all certain about the
> -  return ($id, $target);
> +  return ($target, $target);
>
> lines.

The correct is ($targed, $id) (i.e. the opposite of what it was). But
then the target and the anchor swapped again, and they did continue
not matching.  They only do match that way (we agree in that target
and anchors must match, do we?)

-- 
Francisco Vila. Badajoz (Spain)
www.paconet.org , www.csmbadajoz.com