[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: fix ly:parser-parse-file in an ly file (issue1345041)
From: |
Benjamin Peterson |
Subject: |
Re: fix ly:parser-parse-file in an ly file (issue1345041) |
Date: |
Fri, 4 Jun 2010 11:14:37 -0500 |
2010/6/4 <address@hidden>:
> > Note that this description isn't correct anymore. This patch doesn't
>>
>> actually prevent those functions from segfaulting but adds a new
>> interface ly:parser-include-string. I think ly:parser-parse-string and
>> ly:parser-parse-file should actually be banned in .ly files.
>
> If ly:parser-include-string offers all the functionality of
> ly:parser-parse-string and ly:parser-parse-file, the latter should be
> implemented in terms of the former (rather than segfaulting in some
> situations) for compatibility.
ly:parser-parse-string and ly:parser-parse-file try to run the whole
translation tool chain, which as far as I can tell is not a use case.
I think it is appropriate to add a new interface because it does
something different and more useful.
--
Regards,
Benjamin