|
From: | Marc Hohl |
Subject: | Re: Dependency of 'transparent and 'whiteout (issue1681043) |
Date: | Mon, 21 Jun 2010 10:47:00 +0200 |
User-agent: | Thunderbird 2.0.0.24 (X11/20100317) |
address@hidden schrieb:
LGTM. http://codereview.appspot.com/1681043/diff/1/2 File lily/grob.cc (right): http://codereview.appspot.com/1681043/diff/1/2#newcode126 lily/grob.cc:126: bool grob_transparent = to_boolean (get_property ("transparent")); This is a bit fussy. `transparent' will do, since it's clear from the file we're working with grobs and grob-properties. http://codereview.appspot.com/1681043/diff/1/2#newcode127 lily/grob.cc:127: whitespace error http://codereview.appspot.com/1681043/show
I just saw you corrected it and pushed, thanks! Marc
[Prev in Thread] | Current Thread | [Next in Thread] |