lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Regtests: add missing descriptions (half fix 1206) (issue2103043)


From: Carl . D . Sorensen
Subject: Re: Regtests: add missing descriptions (half fix 1206) (issue2103043)
Date: Thu, 02 Sep 2010 16:49:59 +0000

LGTM, with one suggestion.

THanks!


http://codereview.appspot.com/2103043/diff/1/7
File input/regression/predefined-fretboards.ly (right):

http://codereview.appspot.com/2103043/diff/1/7#newcode4
input/regression/predefined-fretboards.ly:4: texidoc = "Some fretboards
have been predefined.
I'd probably change it to read "Predefined fretboards and chord shapes
can be added"

The point of this test is adding new predefineds, not using existing
predefineds

http://codereview.appspot.com/2103043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]