Re: T1224: Avoid using deprecated %module-public-interface in initialization (issue2083043)

[ianhulin44]

http://www.codereview.appspot.com/2083043/diff/1/2
File lily/ly-module.cc (right):

http://www.codereview.appspot.com/2083043/diff/1/2#newcode36
lily/ly-module.cc:36: SCM maker =
ly_lily_module_constant("make-module");
On 2010/09/02 00:24:02, Neil Puttock wrote:
> ly_lily_module_constant ("make-module");

Done.

http://www.codereview.appspot.com/2083043/diff/1/2#newcode38
lily/ly-module.cc:38: /* Look up and call Guile module-export-all! or
Lilypond-defined
On 2010/09/02 00:24:02, Neil Puttock wrote:
> LilyPond

Will re-draft the comment after "or..."
...or, when using Guile V1.8, the compatible shim defined in the
Lilypond code.

http://www.codereview.appspot.com/2083043/diff/1/4
File scm/lily.scm (right):

http://www.codereview.appspot.com/2083043/diff/1/4#newcode200
scm/lily.scm:200: (define-public (guile-v2 )
On 2010/09/02 00:24:02, Neil Puttock wrote:
> (guile-v2)

Done.

http://www.codereview.appspot.com/2083043/diff/1/4#newcode223
scm/lily.scm:223: (cond-expand
On 2010/09/02 00:24:02, Neil Puttock wrote:
> remove

> all this belongs in a separate patch

OK, will remove code, make the comment one big TODO and raise two
trackers,
one re new Guile V2.0 modules now needed by Lily (ice-9 curried
definitions) and another for modules which Guile V2.0 has moved into its
base code as of 2.0 e.g. (ice-syncase).

http://www.codereview.appspot.com/2083043/diff/1/4#newcode288
scm/lily.scm:288: (ly:error(_"cannot find: ~A") x))
On 2010/09/02 00:24:02, Neil Puttock wrote:
> revert

Done.

http://www.codereview.appspot.com/2083043/diff/1/4#newcode846
scm/lily.scm:846: ;; we want the failed-files noticed in the aggregrate
logfile.
On 2010/09/02 00:24:02, Neil Puttock wrote:
> it's `notice' (noun), referring to the message below

> (though you can fix the typo :)

;; Ensure a notice re failed files is written to aggregate logfile.

http://www.codereview.appspot.com/2083043/