[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: T1247 - Conditionally do (use-modules (ice-9 curried-definitions)) i
From: |
ianhulin44 |
Subject: |
Re: T1247 - Conditionally do (use-modules (ice-9 curried-definitions)) if running with Guile V2, (issue2219044) |
Date: |
Sat, 25 Sep 2010 23:39:33 +0000 |
http://codereview.appspot.com/2219044/diff/1/scm/lily.scm
File scm/lily.scm (right):
http://codereview.appspot.com/2219044/diff/1/scm/lily.scm#newcode226
scm/lily.scm:226: (ly:progress (_ "Using (ice-9 curried-definitions)
module\n"))
On 2010/09/25 21:45:21, Neil Puttock wrote:
(if (ly:get-option 'verbose)
(ly:message (_ "Using (ice-9 curried-definitions) module")))
(use-modules (ice-9 curried-definitions)))
Looking at warn.cc I can see ly:progress and ly:message are synonymous.
Does this mean there's a standard we should use ly:message for all
informational (non error/warning) messages? Is it documented?
I'll change to use ly:message.
http://codereview.appspot.com/2219044/diff/1/scm/lily.scm#newcode231
scm/lily.scm:231: (_ "module (ice-9 curried-definitions) not in Guile
1.8\n")))))
On 2010/09/25 21:45:21, Neil Puttock wrote:
I don't think ths message is necessary.
I felt some indication was useful at run-time that we weren't trying to
use the V2-specific modules when running with --verbose using Guile
V1.8.
http://codereview.appspot.com/2219044/
- Re: T1247 - Conditionally do (use-modules (ice-9 curried-definitions)) if running with Guile V2, (issue2219044),
ianhulin44 <=