lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fix #888: Add ly:stencil-scale. (issue2275042)


From: n . puttock
Subject: Re: Fix #888: Add ly:stencil-scale. (issue2275042)
Date: Sun, 24 Oct 2010 11:46:39 +0000

Reviewers: Valentin Villenave, Patrick McCarty,

Message:
On 2010/10/04 10:36:47, Valentin Villenave wrote:

Hi Neil, your patch looks awesome!

Thanks.

Wouldn't a number-pair be more consistent with existing markup
commands such as
translate-scaled?

Yep, and it saves a hash too. :)

Cheers,
Neil



Description:
Fix #888: Add ly:stencil-scale.

* lily/stencil-interpret.cc (interpret_stencil_expression):

  interpret new stencil command `scale-stencil', unscaling offset of
body to
  compensate for change in output scale

* lily/stencil-scheme.cc (ly_stencil_scale):

  export new function `ly:stencil-scale'

* lily/stencil.cc, include/stencil.hh (scale):

  new method for scaling stencils

* scm/define-markup-commands.scm (scale):

  new markup command

* scm/define-stencil-commands.scm

  (ly:all-stencil-commands): add stencil commands for setting and
resetting
  scale (`setscale', `resetscale')

  (ly:all-output-backend-commands): add `scale-stencil' command

* scm/output-ps.scm, output-svg.scm (setscale, resetscale):

  implement stencil outputters for scaling

Please review this at http://codereview.appspot.com/2275042/

Affected files:
  A input/regression/stencil-scale.ly
  M lily/include/stencil.hh
  M lily/stencil-interpret.cc
  M lily/stencil-scheme.cc
  M lily/stencil.cc
  M scm/define-markup-commands.scm
  M scm/define-stencil-commands.scm
  M scm/output-ps.scm
  M scm/output-svg.scm





reply via email to

[Prev in Thread] Current Thread [Next in Thread]