Re: Wrong loop boundaries when iterating over markup list (issue4236047)

[hanwenn]

http://codereview.appspot.com/4236047/diff/1/lily/include/prob.hh
File lily/include/prob.hh (right):

http://codereview.appspot.com/4236047/diff/1/lily/include/prob.hh#newcode59
lily/include/prob.hh:59: void set_boolean_property (const char *sym,
bool val);
can you use set_property() rather than adding this method?  set_property
memoizes the symbol lookup.

http://codereview.appspot.com/4236047/diff/1/lily/paper-book.cc
File lily/paper-book.cc (right):

http://codereview.appspot.com/4236047/diff/1/lily/paper-book.cc#newcode542
lily/paper-book.cc:542: (!scm_is_pair(scm_cdr(list))) && (list !=
texts)); // I am last && not first
why not introduce a

  Prob *first = 0;
  Prob *last = 0;

and init those in the loop? That would make the logic more explicit than
having comments.

http://codereview.appspot.com/4236047/