Re: Doc: NR more examples to Repeats for beat slashes (issue4273125)

[pkx166h]

Reviewers: Neil Puttock, Graham Percival,

Message:
On 2011/03/28 20:04:37, Neil Puttock wrote:
> Hi James,

> Thanks for doing this.  It LGTM (but don't forget to remove the
@knownissue)

Thanks, I missed that. Done.


> Just two suggestions for you: a changes.itely entry is probably a good
idea,

Yes. Done. Included in this patch as if this patch is reverted forany
reason it will also revert the changes.tely edits too.

and
> the @seealso for the Internals Reference needs the following items
added:

> DoublePercentEvent
> DoubleRepeatSlash
> Double_percent_repeat_engraver
> RepeatSlashEvent
> Slash_repeat_engraver

Thanks. Done.


Description:
Doc: NR more examples to Repeats for beat slashes

This is for Tracker Issue #1574

Showing short-duration repeats and beat slashes along with
mixed length notes.

Please review this at http://codereview.appspot.com/4273125/

Affected files:
  M Documentation/changes.tely
  M Documentation/notation/repeats.itely


Index: Documentation/changes.tely
diff --git a/Documentation/changes.tely b/Documentation/changes.tely
index  
eaa4f1b7d1bb4e79a06ed18782f4a2189cc64722..10b743f192d521158ca6ecf200f59eb5e74c0e12  
100644
--- a/Documentation/changes.tely
+++ b/Documentation/changes.tely
@@ -62,6 +62,11 @@ which scares away people.
 @end ignore

 @item
+Single beat repeats for sixteenth or shorter notes and beat repeats for
+measures containing notes of varying durations are now supported.
+
+
address@hidden
 Lilypond typesets woodwind fingering charts.
 @lilypond
 \relative c' {
Index: Documentation/notation/repeats.itely
diff --git a/Documentation/notation/repeats.itely  
b/Documentation/notation/repeats.itely
index  
1e8de840be18135c816e3920ddc1fe0cb472518b..a14ef8db09be0fa1f7cce39192756e4aca7410b9  
100644
--- a/Documentation/notation/repeats.itely
+++ b/Documentation/notation/repeats.itely
@@ -578,22 +578,35 @@ where @address@hidden is a music expression.
 Patterns that are shorter than one measure are replaced by slashes.

 @lilypond[verbatim,quote,relative=2]
+\repeat percent 4 { c128 d e f }
+\repeat percent 4 { c64 d e f }
+\repeat percent 5 { c32 d e f}
+\repeat percent 4 { c16 d e f}
 \repeat percent 4 { c8 d }
 \repeat percent 4 { c4 }
 \repeat percent 2 { c2 }
 @end lilypond

-Patterns of one or two measures are replaced by percent-like signs.
+Patterns of one or two measures are replaced by percent-like symbols.

 @lilypond[verbatim,quote,relative=2]
-\repeat percent 3 { c4 d e f }
-\repeat percent 4 { c2 d }
+\repeat percent 2 { c4 d e f }
+\repeat percent 2 { c2 d }
+\repeat percent 2 { c1 }
 @end lilypond

 @lilypond[verbatim,quote,relative=2]
 \repeat percent 3 { c4 d e f | c2 g' }
 @end lilypond

+Patterns that are shorter than one measure but contain mixed durations
+use a double-percent symbol.
+
address@hidden,quote,relative=2]
+\repeat percent 4 { c8. <d f>16 }
+\repeat percent 2 { \times 2/3 { r8 c d } e4 }
address@hidden lilypond
+
 @snippets

 @lilypondfile[verbatim,lilyquote,texidoc,doctitle]
@@ -605,7 +618,6 @@ Patterns of one or two measures are replaced by  
percent-like signs.
 @lilypondfile[verbatim,lilyquote,texidoc,doctitle]
 {isolated-percent-repeats.ly}

-
 @seealso
 Music Glossary:
 @rglos{percent repeat},
@@ -616,23 +628,16 @@ Snippets:

 Internals Reference:
 @rinternals{RepeatSlash},
address@hidden,
address@hidden,
 @rinternals{PercentRepeat},
address@hidden,
address@hidden,
address@hidden,
 @rinternals{DoublePercentRepeat},
 @rinternals{DoublePercentRepeatCounter},
address@hidden,
address@hidden
-
-
address@hidden
-
-Only three kinds of percent repeats are supported: a single slash
-representing a single beat (regardless of the duration of the repeated
-notes); a single slash with dots representing one full measure; and
-two slashes with dots crossing a bar line representing two full
-measures.  Neither multiple slashes representing single beat repeats
-consisting of sixteenth or shorter notes, nor two slashes with dots
-representing single beat repeats consisting of notes of varying
-durations, are supported.
address@hidden,
address@hidden


 @node Tremolo repeats