Re: Suppress continuing LyricHyphen under grace note at start of line (issue4313047)

[Trevor Daniels]

address@hidden wrote Monday, March 28, 2011 9:17 PM

> I hope you don't mind the following late comments. :)

Not at all; I pushed it earlier than I should anyway.  Thanks!

> http://codereview.appspot.com/4313047/diff/1/input/regression/lyric-hyphen-grace.ly#newcode15
> input/regression/lyric-hyphen-grace.ly:15: \lyricmode {
> remove (implicit in \addlyrics)

Done

> http://codereview.appspot.com/4313047/diff/1/lily/lyric-hyphen.cc#newcode46
> lily/lyric-hyphen.cc:46: if (Paper_column::when_mom
> (bounds[LEFT]->get_column ()).grace_part () != Rational (0)
> I think you could fold this into the existing code below:
>
> if (bounds[LEFT]->break_status_dir ()
>     && (Paper_column::when_mom (bounds[LEFT]).main_part ()
>     == Paper_column::when_mom (bounds[RIGHT]->get_column 
> ()).main_part
> ()))

Done, but I don't like emacs' indentation here.
Do you think this makes it clearer?

> http://codereview.appspot.com/4313047/

Trevor