Re: Adds beam collision avoidance to auto beaming (issue4290069)

[address@hidden]

On Mar 29, 2011, at 10:12 PM, Colin Campbell wrote:

On 11-03-29 04:54 PM, address@hidden wrote:

On Mar 28, 2011, at 6:39 PM, address@hidden wrote:

Looks much more readable, thanks!

http://codereview.appspot.com/4290069/diff/11001/lily/beam-collision-engraver.cc

File lily/beam-collision-engraver.cc (right):

http://codereview.appspot.com/4290069/diff/11001/lily/beam-collision-engraver.cc#newcode59

lily/beam-collision-engraver.cc:59: // Start conisdering grobs at the

first grob whose end falls at or after the beam's beginning.

typo: conisdering

http://codereview.appspot.com/4290069/

Can somebody please test this patch out on a few thorny keyboard pieces before I push it?  It will make beam collision kick in on all beams, and I want to make sure that I don't run into the same issue I did w/ accidentals.  I would do it myself, but I am not in possession of anything that could really test this to the max.

Cheers,

MS

If you point me toward a few thorny keyboard pieces, I can run some tests for you, Mike.

Colin

Thanks Colin!

I don't have any, but I'm assuming that some of these would suffice:

http://www.mutopiaproject.org/cgibin/make-table.cgi?searchingfor=debussy

http://www.mutopiaproject.org/cgibin/make-table.cgi?searchingfor=scriabin

http://www.mutopiaproject.org/cgibin/make-table.cgi?searchingfor=chopin

Cheers,

MS