lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: please close rietveld issues after pushing


From: Reinhold Kainhofer
Subject: Re: please close rietveld issues after pushing
Date: Thu, 7 Apr 2011 23:39:54 +0200
User-agent: KMail/1.13.5 (Linux/2.6.35-28-generic; KDE/4.6.1; i686; ; )

Am Donnerstag, 7. April 2011, um 23:23:45 schrieb Jan Warchoł:
> 2011/4/7 Graham Percival <address@hidden>:
> > Hi guys,
> > 
> > If you've put anything on rietveld recently, please go here:
> > http://codereview.appspot.com/mine
> > 
> > You'll probably see a bunch of issues under "created by me".  If you
> > recognize anything that you pushed, could you go to that issue, click
> > on "edit issue", then click on "close" and save it?  I'm toying with
> > various automatic methods to help keep of patches, and clearing out
> > patches that have already been pushed would certainly help!
> 
> I see some, but they were pushed by you. Should i close them too or is
> this message aimed at people with git push ability?

Yes, please close them. One problem with rietveld is that only the creator can 
close or edit a review, so if someone pushes your patches, only you can mark 
them as closed on rietveld.

Cheers,
Reinhold
-- 
------------------------------------------------------------------
Reinhold Kainhofer, address@hidden, http://reinhold.kainhofer.com/
 * Financial & Actuarial Math., Vienna Univ. of Technology, Austria
 * http://www.fam.tuwien.ac.at/, DVR: 0005886
 * LilyPond, Music typesetting, http://www.lilypond.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]