Re: Allows users to request that beam collision occur on the Voice level. (issue4367042)

[mtsolo]

New patch set uploaded.


http://codereview.appspot.com/4367042/diff/1/input/regression/beam-collision-voice-only.ly
File input/regression/beam-collision-voice-only.ly (right):

http://codereview.appspot.com/4367042/diff/1/input/regression/beam-collision-voice-only.ly#newcode1
input/regression/beam-collision-voice-only.ly:1: \version "2.13.58"
On 2011/04/08 19:19:18, Neil Puttock wrote:
> 2.13.59

Done.

http://codereview.appspot.com/4367042/diff/1/input/regression/beam-collision-voice-only.ly#newcode9
input/regression/beam-collision-voice-only.ly:9: << { c8 [s c ] } \\ {
s8 c' s8 } >>
On 2011/04/08 19:19:18, Neil Puttock wrote:
> c8[ s c]

Done.

http://codereview.appspot.com/4367042/diff/1/input/regression/beam-collision-voice-only.ly#newcode10
input/regression/beam-collision-voice-only.ly:10: c, [des' ]
On 2011/04/08 19:19:18, Neil Puttock wrote:
> c,[ des']

Done.

http://codereview.appspot.com/4367042/diff/1/input/regression/beam-collision-voice-only.ly#newcode12
input/regression/beam-collision-voice-only.ly:12: << { c,8 [s c ] } \\ {
s8 c' s8 } >>
On 2011/04/08 19:19:18, Neil Puttock wrote:
> c,8[ s c]

Done.

http://codereview.appspot.com/4367042/diff/1/input/regression/beam-collision-voice-only.ly#newcode13
input/regression/beam-collision-voice-only.ly:13: c, [des'! ]
On 2011/04/08 19:19:18, Neil Puttock wrote:
> c,[ des'!]

Done.

http://codereview.appspot.com/4367042/diff/1/lily/beam-collision-engraver.cc
File lily/beam-collision-engraver.cc (right):

http://codereview.appspot.com/4367042/diff/1/lily/beam-collision-engraver.cc#newcode52
lily/beam-collision-engraver.cc:52: Beam_collision_engraver::less
(Grob_info i, Grob_info j)
On 2011/04/08 19:19:18, Neil Puttock wrote:
> This name implies a comparison between engravers.  It would make more
sense
> defining Grob_info::less ().


Done.

http://codereview.appspot.com/4367042/diff/1/scm/define-grobs.scm
File scm/define-grobs.scm (right):

http://codereview.appspot.com/4367042/diff/1/scm/define-grobs.scm#newcode358
scm/define-grobs.scm:358: (collision-voice-only . #f)
On 2011/04/08 19:19:18, Neil Puttock wrote:
> remove

Done.

http://codereview.appspot.com/4367042/