lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Changes the Y offset callback of multi-measure rest. (issue4389047)


From: mtsolo
Subject: Re: Changes the Y offset callback of multi-measure rest. (issue4389047)
Date: Wed, 13 Apr 2011 10:51:55 +0000

The only (big) issue with this patch as it stands is that, at some point
in the chain, the Y-offset of the multi-measure-rest is being fed into
that which controls MultiMeasureRestText positioning.  Before, it would
receive the Y-offset of 0, which did not bump these texts (i.e.
fermataMarkup) up.  Now, it receives the new Y-offset, which causes
these grobs to rise above their prior placement.

I don't really where this bumping-up of MultiMeasureRestText grobs is
done...maybe Side_position_interface::general_side_position ?  Thoughts
would be appreciated!

Cheers,
Mike

http://codereview.appspot.com/4389047/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]