lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Another fix candidate for issue 1613. (issue4426072)


From: Carl . D . Sorensen
Subject: Re: Another fix candidate for issue 1613. (issue4426072)
Date: Sun, 01 May 2011 00:56:38 +0000

Looks good to me -- just a comment on a variable name.


http://codereview.appspot.com/4426072/diff/1001/lily/beam.cc
File lily/beam.cc (right):

http://codereview.appspot.com/4426072/diff/1001/lily/beam.cc#newcode1272
lily/beam.cc:1272: Interval vorboten;
We shouldn't use german words for variable names, I think.  English is
the standard code language for lilypond.

And if we do, we should spell it properly -- I'm pretty sure the
spelling is verboten.

Perhaps "disallowed"?

http://codereview.appspot.com/4426072/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]