Re: Doc: NR rewrite of 3.2 Titles and Headers (issue4124056)

[pkx166h]

Draft 8


http://codereview.appspot.com/4124056/diff/32001/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):

http://codereview.appspot.com/4124056/diff/32001/Documentation/notation/input.itely#newcode667
Documentation/notation/input.itely:667: Text fields left unset in a
@code{\header} block are replaced with
On 2011/05/04 17:08:39, Carl wrote:
> This paragraph has three different ideas -- null markups, piece and
opus, and
> forcing titles to start on a new page.

> They should probably be separated into three different paragraphs.

Actually I have split it into two and removed the middle part as the
example above states this already in the comment within the verbatim
@lilypond example.

http://codereview.appspot.com/4124056/diff/32001/Documentation/notation/input.itely#newcode674
Documentation/notation/input.itely:674: @example
On 2011/05/04 23:32:36, Graham Percival wrote:
> We just spent a month working on a8landscape, precisely to avoid
having an
> @example like this.  Change to @lilypond.

Yes we did, you'll also remember that you sent out an email to dev
asking for help as I struggled to get this working and it seemed to me
that there are some very specific places where it will and won't work.

http://article.gmane.org/gmane.comp.gnu.lilypond.general/63567/

:(

http://codereview.appspot.com/4124056/diff/32001/Documentation/notation/input.itely#newcode719
Documentation/notation/input.itely:719: clickable link
(@url{http://www.lilypond.org}).
On 2011/05/04 23:32:36, Graham Percival wrote:
> Don't talk about it.  Having the example already shows you the default
tagline.

Done.

http://codereview.appspot.com/4124056/diff/32001/Documentation/notation/input.itely#newcode730
Documentation/notation/input.itely:730: c4 d e f
On 2011/05/04 23:32:36, Graham Percival wrote:
> IIRC this produces two lines (I haven't compiled it).  If so, do we
need two
> lines?  Why not just have one bar?

No reason.


> Also, do we need a title?  This is an example for a tagline, right?

Yes but it does show it all in context - i.e. a 'whole page' from top to
bottom. It's odd that you'd have a tagline and no title for a finished
score (in my opinion), but again I have no strong feelings about
removing the titles.

Done

http://codereview.appspot.com/4124056/diff/32001/Documentation/notation/input.itely#newcode748
Documentation/notation/input.itely:748: c4 d e f
On 2011/05/04 23:32:36, Graham Percival wrote:
> This is good, but previous comments apply as well.  Lose the title and
one bar.

Done.

http://codereview.appspot.com/4124056/diff/32001/Documentation/notation/input.itely#newcode755
Documentation/notation/input.itely:755: To remove the @code{tagline} set
the value to to @code{##f}.
On 2011/05/04 23:32:36, Graham Percival wrote:
> this is fine; no need to another @lilypond here.

Done.

http://codereview.appspot.com/4124056/diff/32001/Documentation/notation/input.itely#newcode937
Documentation/notation/input.itely:937:
On 2011/05/04 17:08:39, Carl wrote:
> Need @seealso for the @ref in this node -- Title blocks explained,
Default
> layout of book and score title blocks,.

This section is not being done until the above node is complete - see
previous comment by Graham

http://codereview.appspot.com/4124056/diff/32001/Documentation/notation/input.itely#newcode987
Documentation/notation/input.itely:987: @end lilypond
On 2011/05/04 17:08:39, Carl wrote:
> Need @seealso here, with all of the @ref in this node (Default layout
of book
> and title blocks).

This section is not being done until the above node is complete - see
previous comment by Graham

http://codereview.appspot.com/4124056/