Re: Better approach to fixing the TabVoice glissando problem. (issue4438092)

[Carl Sorensen]

On 5/6/11 8:52 AM, "address@hidden" <address@hidden> wrote:

> On May 4, 2011, at 1:49 AM, Neil Puttock wrote:
> 
>> On 3 May 2011 23:44, address@hidden <address@hidden> wrote:
>>> Back to http://codereview.appspot.com/4438092/, it seems as if this doesn't
>>> screw up the harmonics problem.
>> 
>> But they're already screwed (probably since the Tab_harmonic_engraver
>> was removed and the harmonics moved to the TabNoteHead print
>> function).
>> 
> 
> Carl - I know you're slammed w/ a paper, but do you have time to apply my
> patch (as well as the failed commit that I pushed to master), look into the
> TabNoteHead print function, and see if there's a more elegant way to do what
> I'm doing w/o messing up the harmonics?  I can put some time into it in a
> couple weeks, but I find that things go a lot quicker when the person who
> wrote a chunk of code sizes up the problem.


OK, I'm on this now.  The problem is that the procedure called to determine
frets and strings doesn't respect and maintain note ordering.  And the
ordering varies with whether or not strings are specified.  I've modified
the tablature-harmonics regtest to show the problem, and a fix will be
coming soon.

I think that will solve your problem.  Once I have tab harmonics
bulletproof, I'll check the glissando stuff out.

Thanks,

Carl