[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fix determine-frets so that it preserves note order (issue4518045)
From: |
n . puttock |
Subject: |
Re: Fix determine-frets so that it preserves note order (issue4518045) |
Date: |
Mon, 09 May 2011 18:34:44 +0000 |
Hi Carl,
LGTM, apart from some indentation issues.
One question for you though: do you think the refactoring is an
improvement on the current code? You could for example achieve the same
result with the following:
(sort string-fret-fingering-tuples
(lambda (a b) (> (car a) (car b)))))
;; end of determine-frets-and-strings
Cheers,
Neil
http://codereview.appspot.com/4518045/